CHIA-2381 Validate fast forward spends before adding their spend bundle to the mempool #19272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmineKhaldi
added
the
Changed
AmineKhaldi
changed the title
AmineKhaldi
force-pushed
the
ensure_ff_spends_have_latest_unspent
branch
from
01f2443 to
313c6e4
Compare
arvidn
reviewed
Feb 16, 2025
AmineKhaldi
force-pushed
the
ensure_ff_spends_have_latest_unspent
branch
from
313c6e4 to
81b6e5d
Compare
arvidn
reviewed
Feb 16, 2025
AmineKhaldi
force-pushed
the
ensure_ff_spends_have_latest_unspent
branch
from
81b6e5d to
51339fb
Compare
arvidn
reviewed
Feb 16, 2025
AmineKhaldi
force-pushed
the
ensure_ff_spends_have_latest_unspent
branch
from
51339fb to
1639fdd
Compare
emlowe
reviewed
Feb 16, 2025
arvidn
previously approved these changes
Feb 17, 2025
emlowe
previously approved these changes
Feb 17, 2025
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
merge_conflict
…mempool. Make sure that all fast forward spends of a spend bundle would still have unspent coins.
AmineKhaldi
force-pushed
the
ensure_ff_spends_have_latest_unspent
branch
from
1639fdd to
a6758ca
Compare
github-actions
bot
removed
the
merge_conflict
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
emlowe
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose:
Make sure that all fast forward spends of a spend bundle would still have unspent coins.
Current Behavior:
We can accept a spend bundle with fast forward spends that do not currently have latest unspent coins.
New Behavior:
We reject spend bundles like that with
DOUBLE_SPENDerror.