Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Feed API Get Request - Home page #114

Closed
hardikpatil opened this issue Apr 7, 2023 · 5 comments · Fixed by #153
Closed

Add Feed API Get Request - Home page #114

hardikpatil opened this issue Apr 7, 2023 · 5 comments · Fixed by #153
Assignees
Labels
backend concerns backend/API presentation

Comments

@hardikpatil
Copy link
Contributor

hardikpatil commented Apr 7, 2023

Feed API Get Request

@briswells
Copy link
Contributor

briswells commented Apr 7, 2023

@hardikpatil to clarify the exact data you want. Are you looking for expired and soon to expire items, with field such as, name, expiration date, donation date, and quantity? Also what time period would you be looking for, I think it would be better to limit the duration returned on the back end vs returning all items and you doing the math on the front end.

@hardikpatil
Copy link
Contributor Author

hardikpatil commented Apr 8, 2023

@hardikpatil to clarify the exact data you want. Are you looking for expired and soon to expire items, with field such as, name, expiration date, donation date, and quantity? Also what time period would you be looking for, I think it would be better to limit the duration returned on the back end vs returning all items and you doing the math on the front end.

Yes, in the following format, for instance ,
id: number; item: string; expiry_date: string; added_date: string; quantity: number
{ id: 1, item: "Rice", expiry_date: "2023-08-12", quantity:1, added_date:"2023-04-25" }

@AbhinavReddy-Dev
Copy link
Contributor

@briswells @hardikpatil There is an expiry page that contains the information of the expired and expiring items information. I think the feed should be more of the recent activity of the pantry, like items added, donors added, items expired, etc. Please add to this idea.

@briswells
Copy link
Contributor

@briswells @hardikpatil There is an expiry page that contains the information of the expired and expiring items information. I think the feed should be more of the recent activity of the pantry, like items added, donors added, items expired, etc. Please add to this idea.

We 100% should eventually but I don't think we're there yet. I believe the idea of this is to recreate the old application dashboard feed using the new UI and database. That feed only dealt with expiring items as that was the only thing required by the specs. We could add this at a later time but adding to many features now could over complicate things when the app is in an unstable state.

@hardikpatil hardikpatil assigned TJSidhu1 and unassigned hardikpatil Apr 11, 2023
@hardikpatil hardikpatil changed the title Add Feed API Get Request Add Feed API Get Request - Home page Apr 11, 2023
@MSS-Shalavritha MSS-Shalavritha self-assigned this Apr 11, 2023
@hardikpatil hardikpatil added the backend concerns backend/API presentation label Apr 14, 2023
@briswells
Copy link
Contributor

@hardikpatil Just finished the code. I'm going to rebase with main soon. Should I open a PR into main or should I merge into a different branch?

@briswells briswells linked a pull request Apr 14, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend concerns backend/API presentation
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants