Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Donor page improvements #77 #115

Merged
merged 5 commits into from
Apr 12, 2023
Merged

Donor page improvements #77 #115

merged 5 commits into from
Apr 12, 2023

Conversation

murthy-001
Copy link
Contributor

@murthy-001 murthy-001 commented Apr 9, 2023 •
edited by hardikpatil
Loading

@murthy-001 murthy-001 changed the base branch from main to frontend April 9, 2023 08:25
@murthy-001 murthy-001 changed the title Donor page improvements#77 Donor page improvements #77 Apr 9, 2023
@AbhinavReddy-Dev
Copy link
Contributor

@murthy-001 There are some issues with the build, can you please run npm run build locally to get rid of the errors? Let me know if you want me to join in resolving the build errors.

@AbhinavReddy-Dev
Copy link
Contributor

@murthy-001 There are some issues with the build, can you please run npm run build locally to get rid of the errors? Let me know if you want me to join in resolving the build errors.

@murthy-001 You can comment the statements that are not used and the build will not fail, it is currently failing as the warnings are treated as errors. Please check the details of the failed build.

@DevangRaval1 DevangRaval1 self-requested a review April 10, 2023 16:31
@DevangRaval1
Copy link
Contributor

ReviewMurthy

The page works. However, there are no validations for the add Donor Entry form

DevangRaval1
DevangRaval1 reviewed Apr 10, 2023
View reviewed changes
Copy link
Contributor

@DevangRaval1 DevangRaval1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also the build tests failing

@AbhinavReddy-Dev AbhinavReddy-Dev added the UI Concerns UI presentation label Apr 10, 2023
@murthy-001
Updated the donor page changes #77
f2e83eb 
-> Updated E-mail validation on new donor entry page
-> Updated Add donor button appearance
@murthy-001
Resolved build errors #77
da4e424
@murthy-001
Resolved build errors #77
82b85ff
@AbhinavReddy-Dev AbhinavReddy-Dev self-requested a review April 11, 2023 07:21
@AbhinavReddy-Dev
Copy link
Contributor

@murthy-001 can you please let us know the status of this PR? Were you able to rework on the conflicts?

@murthy-001
Copy link
Contributor Author

murthy-001 commented Apr 11, 2023 via email

@AbhinavReddy-Dev
Copy link
Contributor

I have made the changes and created a PR, please look into it and let me know if anything is missing.
…
On Tue, Apr 11, 2023, 3:18 PM Abhinav Reddy @.> wrote: @murthy-001 https://github.com/murthy-001 can you please let us know the status of this PR? Were you able to rework on the conflicts? — Reply to this email directly, view it on GitHub <#115 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5SWITS7WX43JZ3GS5ZNZ2LXAXKDFANCNFSM6AAAAAAWX7CCEY . You are receiving this because you were mentioned.Message ID: @.>

Did you make a different one? I think it is good to work on the same branch so that the changes are reflected in this PR.

Base automatically changed from frontend to main April 12, 2023 05:01
@hardikpatil hardikpatil changed the base branch from main to frontend April 12, 2023 05:07
Base automatically changed from frontend to main April 12, 2023 06:13
@hardikpatil hardikpatil changed the base branch from main to frontend April 12, 2023 14:23
@hardikpatil hardikpatil self-requested a review April 12, 2023 14:30
hardikpatil
hardikpatil approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@hardikpatil hardikpatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, also validation working as expected #77

Screenshot 2023-04-12 at 07 31 12

DevangRaval1
DevangRaval1 approved these changes Apr 12, 2023
View reviewed changes
Copy link
Contributor

@DevangRaval1 DevangRaval1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@prasannarajezzzy prasannarajezzzy merged commit b8a50d2 into frontend Apr 12, 2023
@prasannarajezzzy prasannarajezzzy deleted the donor-page-improvements#77 branch April 12, 2023 16:34
@prasannarajezzzy prasannarajezzzy restored the donor-page-improvements#77 branch April 12, 2023 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardikpatil hardikpatil hardikpatil approved these changes

@prasannarajezzzy prasannarajezzzy prasannarajezzzy approved these changes

@AbhinavReddy-Dev AbhinavReddy-Dev AbhinavReddy-Dev approved these changes

@DevangRaval1 DevangRaval1 DevangRaval1 approved these changes

@xl26 xl26 Awaiting requested review from xl26

Assignees
No one assigned
Labels
UI Concerns UI presentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@murthy-001 @AbhinavReddy-Dev @DevangRaval1 @hardikpatil @prasannarajezzzy