Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added formik to login page. Fixed issue #120 #121

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Added formik to login page. Fixed issue #120 #121

merged 1 commit into from
Apr 11, 2023

Conversation

priyankavrao97
Copy link
Contributor

@priyankavrao97 priyankavrao97 commented Apr 11, 2023 •
edited
Loading

Improving login form with formik for easy form validation.

@hardikpatil hardikpatil self-requested a review April 11, 2023 06:23
hardikpatil
hardikpatil approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@hardikpatil hardikpatil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks better actually.

Screenshot 2023-04-10 at 23 23 32

SANDESHSOBARAD
SANDESHSOBARAD approved these changes Apr 11, 2023
View reviewed changes
Copy link
Contributor

@SANDESHSOBARAD SANDESHSOBARAD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding formik was a good idea, now looks better.

@priyankavrao97 priyankavrao97 merged commit 26b57d4 into frontend Apr 11, 2023
@priyankavrao97 priyankavrao97 deleted the frontend-loginformik branch April 11, 2023 17:17
@DevangRaval1 DevangRaval1 restored the frontend-loginformik branch April 11, 2023 17:43
@hardikpatil hardikpatil added the UI Concerns UI presentation label Apr 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xl26 xl26 xl26 approved these changes

@hardikpatil hardikpatil hardikpatil approved these changes

@SANDESHSOBARAD SANDESHSOBARAD SANDESHSOBARAD approved these changes

@sathyanarayanan-v sathyanarayanan-v Awaiting requested review from sathyanarayanan-v

Assignees
No one assigned
Labels
UI Concerns UI presentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@priyankavrao97 @xl26 @hardikpatil @SANDESHSOBARAD