-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamically rendering sales table data #133
Conversation
I believe, you already pushed this commit in |
I made some more changes on top of existing code in sale.tsx. So I created
a PR for that.
Thanks.
…On Tue, Apr 11, 2023, 3:45 PM Hardik Patil ***@***.***> wrote:
I believe, you already have push this commit in frontend 3 hours ago
—
Reply to this email directly, view it on GitHub
<#133 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AWY5ZX3DXIF7JJKKYOATEVTXAXNI7ANCNFSM6AAAAAAW2YBML4>
.
You are receiving this because you were assigned.Message ID:
***@***.***>
|
PR Looks good to me, before pushing, just make sure whether your local
|
Hey, if you guys can check Issue #102 we have already started working on it. |
@KishoreMenda @Gajjela-Koushik-Reddy @arshiya19 Please coordinate with @DevangRaval1 on how to take this forward as they have created an issue before this, I believe they do have some code to push. Again, please check the issues before jumping in to work on anything necessary so that the work is not duplicated and wasted in the end. |
Okay, sure. Thanks for letting us know.On Apr 11, 2023 19:33, Abhinav Reddy ***@***.***> wrote:
Hey, if you guys can check Issue #102 we have already started working on it.
@KishoreMenda @Gajjela-Koushik-Reddy @arshiya19 Please coordinate with @DevangRaval1 on how to take this forward as they have created an issue before this, I believe they do have some code to push. Again, please check the issues before jumping in to work on anything necessary so that the work is not duplicated and wasted in the end.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: ***@***.***>
|
For now, holding off approval on this PR since two team worked on same issue without each other knowledge.
contributors - @Gajjela-Koushik-Reddy @arshiya19