Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamically rendering sales table data #133

Closed
wants to merge 1 commit into from

Conversation

KishoreMenda
Copy link
Contributor

contributors - @Gajjela-Koushik-Reddy @arshiya19

@hardikpatil
Copy link
Contributor

hardikpatil commented Apr 11, 2023

I believe, you already pushed this commit in frontend 3 hours ago in #125 before creating this PR so I guess should close this PR

@KishoreMenda
Copy link
Contributor Author

KishoreMenda commented Apr 11, 2023 via email

hardikpatil
hardikpatil previously approved these changes Apr 12, 2023
@hardikpatil
Copy link
Contributor

hardikpatil commented Apr 12, 2023

I made some more changes on top of existing code in sale.tsx. So I created a PR for that. Thanks.

On Tue, Apr 11, 2023, 3:45 PM Hardik Patil @.> wrote: I believe, you already have push this commit in frontend 3 hours ago — Reply to this email directly, view it on GitHub <#133 (comment)>, or unsubscribe https://github.com/notifications/unsubscribe-auth/AWY5ZX3DXIF7JJKKYOATEVTXAXNI7ANCNFSM6AAAAAAW2YBML4 . You are receiving this because you were assigned.Message ID: @.>

PR Looks good to me, before pushing, just make sure whether your local frontend is update with your feature_branch. If not, do following:

  1. git checkout frontend
  2. git fetch origin
  3. git pull origin frontend
  4. git checkout your-feature-branch
  5. git merge frontend
  6. git push origin your-feature-branch

@DevangRaval1
Copy link
Contributor

Hey, if you guys can check Issue #102 we have already started working on it.

@AbhinavReddy-Dev
Copy link
Contributor

Hey, if you guys can check Issue #102 we have already started working on it.

@KishoreMenda @Gajjela-Koushik-Reddy @arshiya19 Please coordinate with @DevangRaval1 on how to take this forward as they have created an issue before this, I believe they do have some code to push. Again, please check the issues before jumping in to work on anything necessary so that the work is not duplicated and wasted in the end.

@skrlett
Copy link
Contributor

skrlett commented Apr 12, 2023 via email

hardikpatil

This comment was marked as duplicate.

@hardikpatil hardikpatil dismissed their stale review April 12, 2023 03:52

For now, holding off approval on this PR since two team worked on same issue without each other knowledge.

Base automatically changed from frontend to main April 12, 2023 05:01
@hardikpatil hardikpatil changed the base branch from main to frontend April 12, 2023 05:07
Base automatically changed from frontend to main April 12, 2023 06:13
@AbhinavReddy-Dev AbhinavReddy-Dev changed the base branch from main to frontend April 12, 2023 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants