Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set eslint no-var rule to error, resolves #181 #221

Merged
merged 1 commit into from
May 1, 2023
Merged

Conversation

jayrevolinskyjr
Copy link
Contributor

This change set the 'no-var' rule to an error to prevent the project from building with the current action workflows. See #181 for further discussion and reasoning.

@jayrevolinskyjr jayrevolinskyjr linked an issue May 1, 2023 that may be closed by this pull request
@parthpandey1 parthpandey1 self-requested a review May 1, 2023 16:47
Copy link
Contributor

@reembot reembot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the discussion. LGTM.

Copy link
Contributor

@parthpandey1 parthpandey1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@jayrevolinskyjr jayrevolinskyjr merged commit cc6967d into main May 1, 2023
@jayrevolinskyjr jayrevolinskyjr deleted the let_vs_var branch May 1, 2023 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Linter vs Build Actions
3 participants