Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly mocked useNavigate Hook for Donors.test #237

Merged
merged 2 commits into from
May 11, 2023

Conversation

chetan2298
Copy link
Contributor

Refers to #231
Earlier due to issues with useNavigate tests were failing , which have now been refactored.
A Few of the older tests have been refactored , new tests for donorview to be written soon.
Raising PR to put in a donor page tests back in the repo . Also removing donors.txt from repo

@chetan2298 chetan2298 linked an issue May 11, 2023 that may be closed by this pull request
Copy link
Contributor

@jayrevolinskyjr jayrevolinskyjr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great on my machine!

Copy link
Contributor

@TanviMahajan11 TanviMahajan11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me , approving for now!
more tests needed to cross threshold.
image

@TanviMahajan11 TanviMahajan11 merged commit b5ba1bb into main May 11, 2023
@TanviMahajan11 TanviMahajan11 deleted the 231-rewrite-donor-page-tests branch May 11, 2023 23:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite Donor Page Tests
4 participants