Add README instructions to run ESLint locally #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jayrevolinskyjr
requested review from
Jooms,
Anoushka444,
parthpandey1,
reembot and
ysiddhapura
jayrevolinskyjr
added
documentation
Jooms
requested changes
Mar 8, 2023
Jooms
reviewed
Mar 8, 2023
jayrevolinskyjr
changed the title
Jooms
previously approved these changes
Mar 8, 2023
There was a problem hiding this comment.
Approved with comment
@jayrevolinskyjr please try to locate one person from #47 who can run the installation command to confirm it works.
If they already ran it locally, then it's fine to proceed.
Jooms
reviewed
Mar 8, 2023
|
Works for me! |
briswells
pushed a commit
that referenced
this pull request
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If reviewing my pull request, please follow instructions shown in changed files or in the 'run_lint_local' branch in the README.md under "Static Build Analysis Tools" for "ESLint" to confirm that it works on your local system.
Should 'running ESLint locally' have it's own section entirely? Currently, I took the liberty to just place it in the "Static Build Analysis Tools" section of the README.md
Completes the 4th task necessary for Issue #47.