Routing and Navigation for React #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated #23 with docker-compose for postgres DB and managment console * Generated table creations, updating #23 * updated .gitignore for postgres-data * Minor schema updates * removed not null requirements to fix circular dependancy issues * Added dummy data script to db init * Added Sequelize to project; created DB tests * Test models for sqlize * Moved passwords out of docker-compose * Converted user to use SQLize * converted app.js and logon to sqlize * converted add_donor and donor routes * converted add_donor and donor routes * Added bind to fix permissions error when running * Added TS support * update README to fix Addrinfo crash * Removed person_id requirement from transaction * added dotenv to fix connection string import * Converted imports to require * Updated app.js connection to sequelize * Updated routes * Cnverted phone number to bigint to resolve overflow issues. * fixed /sign_up crashes * Updated logging and login reject messages * fixed login server crash * removed .ts routes * stopped deserializeUser from returning promise * Updated README with setup instructions * added explicit newlines to readme .env format was being pushed together. I also fixed minor grammar error in setup steps. * Updated readme formatting * Converted models-test into models * removed test code * Bump minimist from 1.2.5 to 1.2.8 Bumps [minimist](https://github.com/minimistjs/minimist) from 1.2.5 to 1.2.8. - [Release notes](https://github.com/minimistjs/minimist/releases) - [Changelog](https://github.com/minimistjs/minimist/blob/main/CHANGELOG.md) - [Commits](minimistjs/minimist@v1.2.5...v1.2.8) --- updated-dependencies: - dependency-name: minimist dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> * Adding compiled model files to ignore * updated package scripts for merge * trying to fix 'npm ci' error in workflow, update actions.yml * back to previous actions.yml * updated package-lock.json file, npm install * added PantryNodeReact path for 'npm ci' and 'npm run build' to actions.yml * swapped run commands in actions.yml previous order was skipping server code * added job for PantryNodeReact to actions.yml * v2- added job for PantryNodeReact to actions.yml * v3- added job for PantryNodeReact to actions.yml * v3- excluding .js .jsx files tsconfig.json * v4- removed in tsconfig.json * v5- removed js files and added in gitignore * added pg_admin to local network * updated DB connection safety check * Created stock model * Updated readme with build instruction * Updated readonly validator to fix linter failure * Update Contributing policy to include mandatory testing and coverage (#58) * Update Contributing policy to include mandatory testing and coverage * Update Contributing policy to include mandatory testing and coverage --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: Brian Wells <[email protected]> Co-authored-by: Mike Murtey <[email protected]> Co-authored-by: briswells <[email protected]> Co-authored-by: Brian S Wells <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Kevin Buffardi <[email protected]> Co-authored-by: Manavi Ghorpade <[email protected]>
…different pages. (#74) * added Material UI support with theme * added eslint * added react-router basic layout * merged files from main * added navigation bar functionality * build test success in local * refactored navigation component * added link wrapper around logo typography in the menu
AbhinavReddy-Dev
requested review from
xl26,
hardikpatil,
sathyanarayanan-v,
prestonmasseyblake and
abhilashSreenivasa
|
Everything seems to work fine. All the routing to pages and navigation works for all the pages. |
|
@AbhinavReddy-Dev is there a reason you added .js versions of the models in this merge? I feel like these should be kept out of the repo as they can be recreated by compiling the typescript. |
hardikpatil
previously approved these changes
Mar 27, 2023
I thought they were included in my fetch, I didn't run the backend in my local at all. |
AbhinavReddy-Dev
dismissed stale reviews from hardikpatil and DevangRaval1
via
cae3c03
AbhinavReddy-Dev
added
feature
|
Works without the .js files in models |
DevangRaval1
approved these changes
Mar 28, 2023
hardikpatil
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added below for React