Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Form Validation on Login-Register View #89 #93

Merged
merged 5 commits into from
Apr 5, 2023
Merged

Form Validation on Login-Register View #89 #93

merged 5 commits into from
Apr 5, 2023

Conversation

hardikpatil
Copy link
Contributor

In this PR:

  • Added minor changes in form (As per docs/Foodbank ER Diagram.png schema , in the sign-up View, added fielda First Name, Last Name replacing Name field)
  • Completed form validation on both login, and register views, with reference to issue Form Validation  #89

@hardikpatil hardikpatil added the UI Concerns UI presentation label Apr 4, 2023
@hardikpatil hardikpatil self-assigned this Apr 4, 2023
shmansa
shmansa approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@shmansa shmansa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

Screenshot (250)
Screenshot (252)
Screenshot (254)
Screenshot (259)
Screenshot (260)
Screenshot (261)
Screenshot (262)

prasannarajezzzy
prasannarajezzzy approved these changes Apr 4, 2023
View reviewed changes
Copy link
Contributor

@prasannarajezzzy prasannarajezzzy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are working fine

@hardikpatil hardikpatil merged commit f709d0a into frontend Apr 5, 2023
@hardikpatil hardikpatil deleted the feature/form-validation-login-register branch April 5, 2023 00:04
@hardikpatil hardikpatil mentioned this pull request Apr 5, 2023
Closed
2 tasks
@AbhinavReddy-Dev
Copy link
Contributor

@hardikpatil @prasannarajezzzy can we please have the updated pages in the Figma for login and signup?

@hardikpatil
Copy link
Contributor Author

@hardikpatil @prasannarajezzzy can we please have the updated pages in the Figma for login and signup?

Oh yes, gotta update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prasannarajezzzy prasannarajezzzy prasannarajezzzy approved these changes

@shmansa shmansa shmansa approved these changes

@prestonmasseyblake prestonmasseyblake Awaiting requested review from prestonmasseyblake

@kushalramakanth kushalramakanth Awaiting requested review from kushalramakanth

@AbhinavReddy-Dev AbhinavReddy-Dev Awaiting requested review from AbhinavReddy-Dev

@parthpandey1 parthpandey1 Awaiting requested review from parthpandey1

@DevangRaval1 DevangRaval1 Awaiting requested review from DevangRaval1

Assignees

@hardikpatil hardikpatil

Labels
UI Concerns UI presentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hardikpatil @AbhinavReddy-Dev @prasannarajezzzy @shmansa