Fixes VSCodeVim#612

Chillee · May 26, 2017 · 28950d5 · 28950d5
1 parent abbd98c
commit 28950d5
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 22 deletions.
diff --git a/package.json b/package.json
@@ -122,7 +122,7 @@
       {
         "key": "tab",
         "command": "extension.vim_tab",
-        "when": "editorFocus && vim.active && vim.mode == 'Normal' && !inDebugRepl"
+        "when": "editorFocus && vim.active && !suggestWidgetVisible && !inDebugRepl"
       },
       {
         "key": "ctrl+r",

diff --git a/src/actions/commands/actions.ts b/src/actions/commands/actions.ts
@@ -27,6 +27,7 @@ export class DocumentContentChangeAction extends BaseAction {
   }[] = [];
 
   public async exec(position: Position, vimState: VimState): Promise<VimState> {
+
     if (this.contentChanges.length === 0) {
       return vimState;
     }

diff --git a/src/actions/commands/insert.ts b/src/actions/commands/insert.ts
@@ -182,20 +182,19 @@ class CommandInsertIndentInCurrentLine extends BaseCommand {
   }
 }
 
-// This breaks tab completion: See https://github.com/VSCodeVim/Vim/issues/1752
-// @RegisterAction
-// export class CommandInsertTabInInsertMode extends BaseCommand {
-//   modes = [ModeName.Insert];
-//   keys = ["<tab>"];
-//   runsOnceForEveryCursor() { return false; }
-
-//   public async exec(position: Position, vimState: VimState): Promise<VimState> {
-//     vimState.recordedState.transformations.push({
-//       type: "tab"
-//     });
-//     return vimState;
-//   }
-// }
+@RegisterAction
+export class CommandInsertTabInInsertMode extends BaseCommand {
+  modes = [ModeName.Insert];
+  keys = ["<tab>"];
+  runsOnceForEveryCursor() { return false; }
+
+  public async exec(position: Position, vimState: VimState): Promise<VimState> {
+    vimState.recordedState.transformations.push({
+      type: "tab"
+    });
+    return vimState;
+  }
+}
 
 @RegisterAction
 export class CommandInsertInInsertMode extends BaseCommand {

diff --git a/test/mode/normalModeTests/motions.test.ts b/test/mode/normalModeTests/motions.test.ts
@@ -464,13 +464,12 @@ suite("Motions in Normal Mode", () => {
     end: ['!one', '!two', '|!three']
   });
 
-  // https://github.com/VSCodeVim/Vim/pull/1753
-  // newTest({
-  //   title: "Can handle dot with I with tab",
-  //   start: ['on|e', 'two', 'three'],
-  //   keysPressed: 'I<tab><Esc>j.j.',
-  //   end: ['  one', '  two', ' | three']
-  // });
+  newTest({
+    title: "Can handle dot with I with tab",
+    start: ['on|e', 'two', 'three'],
+    keysPressed: 'I<tab><Esc>j.j.',
+    end: ['  one', '  two', ' | three']
+  });
 
   newTest({
     title: "Can handle 0",