Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for IQueryable Projections #1446

Merged
merged 41 commits into from
Mar 7, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
4776a59
Added resolver metadata
michaelstaib Feb 4, 2020
924c991
feat(Selection): add project
PascalSenn Feb 4, 2020
bf6c250
Merge branch 'feature_entity_framework' of https://github.com/ChilliC…
PascalSenn Feb 4, 2020
f659a00
feat(Selection): add selection middleware
PascalSenn Feb 4, 2020
1364c30
feat(Selection): add selection attribute
PascalSenn Feb 4, 2020
bd0880b
feat(Resolver): add resolver meta data and parent attribute
PascalSenn Feb 6, 2020
9e1cab0
fix format
PascalSenn Feb 6, 2020
841c12a
feat(Resolver): injecting parent depends on all proeprties
PascalSenn Feb 6, 2020
7814985
feat(Resolver): add context annotator and fix format
PascalSenn Feb 10, 2020
8dacbd4
feat(Resolver): resolver metadata to object field
PascalSenn Feb 10, 2020
e5aeebd
test(Resolver): add tests for resolver meta data
PascalSenn Feb 10, 2020
ef8e779
Merge remote-tracking branch 'origin/version_10_0_0_master' into feat…
michaelstaib Feb 13, 2020
8345948
updated sdk
michaelstaib Feb 13, 2020
4828601
feat(Selection): add selection visitor
PascalSenn Feb 17, 2020
c681897
Merge branch 'feature_entity_framework' of https://github.com/ChilliC…
PascalSenn Feb 17, 2020
2bcd944
feat(Selection): remove Parent(field) finish visitor
PascalSenn Feb 23, 2020
721423a
fix format
PascalSenn Feb 23, 2020
16defc6
Merge branch 'version_10_0_0_master' into feature_entity_framework
michaelstaib Feb 23, 2020
1b780be
feat(Selection): add paging to use selection
PascalSenn Feb 24, 2020
1e627e4
Merge branch 'version_10_0_0_master' into feature_entity_framework
michaelstaib Feb 24, 2020
fb11b69
feat(Selection): add support for nested filter and sort
PascalSenn Feb 25, 2020
3dd56ce
Merge branch 'feature_entity_framework' of https://github.com/ChilliC…
PascalSenn Feb 25, 2020
c3aebd5
feat(Selection): add support for paging & cleanup
PascalSenn Feb 27, 2020
46fa951
cleanup
PascalSenn Feb 27, 2020
ecc0d6c
Merge branch 'version_10_0_0_master' into feature_entity_framework
michaelstaib Feb 28, 2020
704f2ca
test(Selection): add integration tests
PascalSenn Mar 5, 2020
3f8ada7
Merge branch 'feature_entity_framework' of https://github.com/ChilliC…
PascalSenn Mar 5, 2020
2ec13e7
fix format
PascalSenn Mar 5, 2020
6fff609
formatting
michaelstaib Mar 6, 2020
5922da7
using order
michaelstaib Mar 6, 2020
66d1e0a
formatting
michaelstaib Mar 6, 2020
4ee071e
namespaces should be plural
michaelstaib Mar 6, 2020
0ae3111
Added selection to build configuration
michaelstaib Mar 6, 2020
1acc785
feat(Types): remove resolver metadata
PascalSenn Mar 6, 2020
4de986c
Merge branch 'feature_entity_framework' of https://github.com/ChilliC…
PascalSenn Mar 6, 2020
8fbd1b1
feat(Sorting): fix sort
PascalSenn Mar 7, 2020
67cfb4c
feat(Sorting): remove old extension methods
PascalSenn Mar 7, 2020
a495c7b
Merge branch 'version_10_0_0_master' into feature_entity_framework
PascalSenn Mar 7, 2020
4c0767b
test(Selection): fix test cases
PascalSenn Mar 7, 2020
4e07cc7
fixed test project files and updated squadron
michaelstaib Mar 7, 2020
c537201
disabled sql server tests
michaelstaib Mar 7, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/Core/Core/InternalsVisibleTo.cs
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
using System.Runtime.CompilerServices;

[assembly: InternalsVisibleTo("HotChocolate.Types.Selection")]
5 changes: 5 additions & 0 deletions src/Core/Types.Filters/QueryableFilterVisitor.cs
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,11 @@ public Expression<Func<TSource, bool>> CreateFilter<TSource>()
_parameter);
}

public Expression CreateFilter()
{
return Expression.Lambda(Level.Peek().Peek(), _parameter);
}

protected Stack<Queue<Expression>> Level { get; } =
new Stack<Queue<Expression>>();

Expand Down
335 changes: 280 additions & 55 deletions src/Core/Types.Selection.Tests/SelectionTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -147,59 +147,6 @@ public void Execute_Selection_MultipleScalar()
});
}

[Fact]
public void Execute_Selection_Object_Paging()
{
// arrange
Foo[] foos = new[]
{
Foo.Create("aa",1),
Foo.Create("bb",2),
};
Connection<Foo> resultCtx = null;
ISchema schema = SchemaBuilder.New()
.AddQueryType<Query>(
d => d.Field(t => t.Foos)
.Resolver(foos)
.Use(next => async ctx =>
{
await next(ctx);
resultCtx = ctx.Result as Connection<Foo>;
})
.UsePaging<ObjectType<Foo>>()
.UseFiltering()
.UseSorting()
.UseSelection())
.Create();
IQueryExecutor executor = schema.MakeExecutable();

// act
IExecutionResult result = executor.Execute(
"{ foos { nodes { nested { bar } } } }");

// assert
Assert.NotNull(resultCtx);
Assert.Collection(resultCtx.Edges.ToArray(),
x =>
{
Assert.Null(x.Node.Bar);
Assert.Equal(0, x.Node.Baz);
Assert.NotNull(x.Node.Nested);
Assert.Equal("nestedaa", x.Node.Nested.Bar);
Assert.Equal(0, x.Node.Nested.Baz);
Assert.Null(x.Node.ObjectArray);
},
x =>
{
Assert.Null(x.Node.Bar);
Assert.Equal(0, x.Node.Baz);
Assert.NotNull(x.Node.Nested);
Assert.Equal("nestedbb", x.Node.Nested.Bar);
Assert.Equal(0, x.Node.Nested.Baz);
Assert.Null(x.Node.ObjectArray);
});
}

[Fact]
public void Execute_Selection_Object()
{
Expand Down Expand Up @@ -664,6 +611,262 @@ public void Execute_Selection_ArrayDeep()
});
}


[Fact]
public void Execute_Selection_Object_Paging()
{
// arrange
Foo[] foos = new[]
{
Foo.Create("aa",1),
Foo.Create("bb",2),
};
Connection<Foo> resultCtx = null;
ISchema schema = SchemaBuilder.New()
.AddQueryType<Query>(
d => d.Field(t => t.Foos)
.Resolver(foos)
.Use(next => async ctx =>
{
await next(ctx);
resultCtx = ctx.Result as Connection<Foo>;
})
.UsePaging<ObjectType<Foo>>()
.UseFiltering()
.UseSorting()
.UseSelection())
.Create();
IQueryExecutor executor = schema.MakeExecutable();

// act
IExecutionResult result = executor.Execute(
"{ foos { nodes { nested { bar } } } }");

// assert
Assert.NotNull(resultCtx);
Assert.Collection(resultCtx.Edges.ToArray(),
x =>
{
Assert.Null(x.Node.Bar);
Assert.Equal(0, x.Node.Baz);
Assert.NotNull(x.Node.Nested);
Assert.Equal("nestedaa", x.Node.Nested.Bar);
Assert.Equal(0, x.Node.Nested.Baz);
Assert.Null(x.Node.ObjectArray);
},
x =>
{
Assert.Null(x.Node.Bar);
Assert.Equal(0, x.Node.Baz);
Assert.NotNull(x.Node.Nested);
Assert.Equal("nestedbb", x.Node.Nested.Bar);
Assert.Equal(0, x.Node.Nested.Baz);
Assert.Null(x.Node.ObjectArray);
});
}

[Fact]
public void Execute_Selection_DeepPaging()
{
// arrange
Foo[] foos = new[]
{
Foo.Create("aa",1),
Foo.Create("bb",2),
};
IQueryable<Foo> resultCtx = null;
ISchema schema = SchemaBuilder.New()
.AddQueryType<Query>(
d => d.Field(t => t.Foos)
.Resolver(foos)
.Use(next => async ctx =>
{
await next(ctx);
resultCtx = ctx.Result as IQueryable<Foo>;
})
.UseFiltering()
.UseSorting()
.UseSelection())
.Create();
IQueryExecutor executor = schema.MakeExecutable();

// act
IExecutionResult result = executor.Execute(
"{ foos { middlewareList { nodes { bar } } } }");

// assert
Assert.NotNull(resultCtx);
Assert.Collection(resultCtx.ToArray()[0].MiddlewareList,
x =>
{
Assert.Equal("ccaa", x.Bar);
Assert.Equal(0, x.Baz);
Assert.Null(x.Nested);
Assert.Null(x.ObjectArray);
},
x =>
{
Assert.Equal("aaaa", x.Bar);
Assert.Equal(0, x.Baz);
Assert.Null(x.Nested);
Assert.Null(x.ObjectArray);
},
x =>
{
Assert.Equal("bbaa", x.Bar);
Assert.Equal(0, x.Baz);
Assert.Null(x.Nested);
Assert.Null(x.ObjectArray);
});
}

[Fact]
public void Execute_Selection_Nested_Filtering()
{
// arrange
Foo[] foos = new[]
{
Foo.Create("aa",1),
Foo.Create("bb",2),
};
IQueryable<Foo> resultCtx = null;
ISchema schema = SchemaBuilder.New()
.AddQueryType<Query>(
d => d.Field(t => t.Foos)
.Resolver(foos)
.Use(next => async ctx =>
{
await next(ctx);
resultCtx = ctx.Result as IQueryable<Foo>;
})
.UseFiltering()
.UseSorting()
.UseSelection())
.Create();
IQueryExecutor executor = schema.MakeExecutable();

// act
IExecutionResult result = executor.Execute(
"{ foos { middlewareList(where:{bar: \"ccaa\"}) { nodes { bar } } } }");

// assert
Assert.NotNull(resultCtx);
Assert.Single(resultCtx.ToArray()[0].MiddlewareList);
Assert.Collection(resultCtx.ToArray()[0].MiddlewareList,
x =>
{
Assert.Equal("ccaa", x.Bar);
Assert.Equal(0, x.Baz);
Assert.Null(x.Nested);
Assert.Null(x.ObjectArray);
});
}

[Fact]
public void Execute_Selection_Nested_Sorting()
{
// arrange
Foo[] foos = new[]
{
Foo.Create("aa",1),
Foo.Create("bb",2),
};
IQueryable<Foo> resultCtx = null;
ISchema schema = SchemaBuilder.New()
.AddQueryType<Query>(
d => d.Field(t => t.Foos)
.Resolver(foos)
.Use(next => async ctx =>
{
await next(ctx);
resultCtx = ctx.Result as IQueryable<Foo>;
})
.UseFiltering()
.UseSorting()
.UseSelection())
.Create();
IQueryExecutor executor = schema.MakeExecutable();

// act
IExecutionResult result = executor.Execute(
"{ foos { middlewareList(order_by:{baz: ASC, bar: ASC}) { nodes { bar } } } }");

// assert
Assert.NotNull(resultCtx);
Assert.Collection(resultCtx.ToArray()[0].MiddlewareList,
x =>
{
Assert.Equal("aaaa", x.Bar);
Assert.Equal(0, x.Baz);
Assert.Null(x.Nested);
Assert.Null(x.ObjectArray);
},
x =>
{
Assert.Equal("ccaa", x.Bar);
Assert.Equal(0, x.Baz);
Assert.Null(x.Nested);
Assert.Null(x.ObjectArray);
},
x =>
{
Assert.Equal("bbaa", x.Bar);
Assert.Equal(0, x.Baz);
Assert.Null(x.Nested);
Assert.Null(x.ObjectArray);
});
}


[Fact]
public void Execute_Selection_Nested_FilteringAndSorting()
{
// arrange
Foo[] foos = new[]
{
Foo.Create("aa",1),
Foo.Create("bb",2),
};
IQueryable<Foo> resultCtx = null;
ISchema schema = SchemaBuilder.New()
.AddQueryType<Query>(
d => d.Field(t => t.Foos)
.Resolver(foos)
.Use(next => async ctx =>
{
await next(ctx);
resultCtx = ctx.Result as IQueryable<Foo>;
})
.UseFiltering()
.UseSorting()
.UseSelection())
.Create();
IQueryExecutor executor = schema.MakeExecutable();

// act
IExecutionResult result = executor.Execute(
"{ foos { middlewareList(where: {bar_in:[\"aaaa\",\"bbaa\"]}, " +
"order_by:{baz: ASC, bar: ASC}) { nodes { bar } } } }");

// assert
Assert.NotNull(resultCtx);
Assert.Collection(resultCtx.ToArray()[0].MiddlewareList,
x =>
{
Assert.Equal("aaaa", x.Bar);
Assert.Equal(0, x.Baz);
Assert.Null(x.Nested);
Assert.Null(x.ObjectArray);
},
x =>
{
Assert.Equal("bbaa", x.Bar);
Assert.Equal(0, x.Baz);
Assert.Null(x.Nested);
Assert.Null(x.ObjectArray);
});
}

public class Query
PascalSenn marked this conversation as resolved.
Show resolved Hide resolved
{
public IQueryable<Foo> Foos { get; }
Expand All @@ -678,7 +881,6 @@ public class Foo
public NestedFoo Nested { get; set; }

public NestedFoo[] ObjectArray { get; set; }

public List<NestedFoo> ObjectList { get; set; }

public IList<NestedFoo> IObjectList { get; set; }
Expand All @@ -689,6 +891,11 @@ public class Foo

public ISet<NestedFoo> ISet { get; set; }

[UsePaging]
[UseFiltering]
[UseSorting]
public List<NestedFoo> MiddlewareList { get; set; }

public static Foo Create(string bar, int baz)
PascalSenn marked this conversation as resolved.
Show resolved Hide resolved
{
var recursive = new NestedFoo()
Expand Down Expand Up @@ -758,7 +965,25 @@ public static Foo Create(string bar, int baz)
Bar = "iSet" + bar,
Baz = baz * 3
},
}
},
MiddlewareList = new List<NestedFoo>
{
new NestedFoo()
{
Bar = "cc" + bar,
Baz = baz * 1
},
new NestedFoo()
{
Bar = "aa" + bar,
Baz = baz * 1
},
new NestedFoo()
{
Bar = "bb" + bar,
Baz = baz * 2
},
}
};
}
}
Expand Down
Loading