Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for IQueryable Projections #1446

Merged
merged 41 commits into from
Mar 7, 2020
Merged

Added support for IQueryable Projections #1446

merged 41 commits into from
Mar 7, 2020

Conversation

PascalSenn
Copy link
Member

@PascalSenn PascalSenn commented Feb 4, 2020 •
edited
Loading

  • UseSelection
    • Paging
    • Nested Selection? (Is probably needed as we do not have auto dataloder)
  • Parent(String field)
  • ResolverMetadata
    • Investigate on complex object of DependsOn ( e.g. what do we do with Arguments? => Execution Plan preparation)
    • Field Resolver
    • SubscribeResolver!

EdgeCases

  • How do we handle dependencies on sub objects [Parent("bar"]Bar barProperty
    Should we support Paths? [Parent("bar.id")]string id
    If so how are we gonna collect dependencies in this case

@PascalSenn PascalSenn added this to the HC-10.4.0 milestone Feb 4, 2020
@PascalSenn PascalSenn self-assigned this Feb 4, 2020
@michaelstaib michaelstaib mentioned this pull request Feb 7, 2020
Closed
@TheJayMann TheJayMann mentioned this pull request Feb 8, 2020
Closed
michaelstaib
michaelstaib reviewed Feb 17, 2020
View reviewed changes
src/Core/Types/Types/ObjectType.cs Outdated Show resolved Hide resolved
src/Core/Types/Types/ObjectType.cs Outdated Show resolved Hide resolved
src/Core/Types/Types/ObjectType.cs Outdated Show resolved Hide resolved
src/Core/Types/Types/ObjectType.cs Outdated Show resolved Hide resolved
michaelstaib
michaelstaib reviewed Feb 17, 2020
View reviewed changes
src/Core/Types.Tests/Resolvers/ResolverMetadataTests.cs Outdated Show resolved Hide resolved
src/Core/Types.Tests/Resolvers/ResolverMetadataTests.cs Outdated Show resolved Hide resolved
src/Core/Types.Tests/Resolvers/ResolverMetadataTests.cs Outdated Show resolved Hide resolved
src/Core/Types.Tests/Resolvers/ResolverMetadataTests.cs Outdated Show resolved Hide resolved
src/Core/Types.Tests/Resolvers/ResolverMetadataTests.cs Outdated Show resolved Hide resolved
src/Core/Types.Selection.Tests/SelectionTests.cs Outdated Show resolved Hide resolved
src/Core/Types.Selection.Tests/SelectionTests.cs Outdated Show resolved Hide resolved
src/Core/Types.Selection.Tests/SelectionAttributeTests.cs Outdated Show resolved Hide resolved
src/Core/Types/Resolvers/Expressions/Arguments/GetParentMetadataAnnotator.cs Outdated Show resolved Hide resolved
src/Core/Types/Resolvers/Expressions/ResolveCompiler.cs Outdated Show resolved Hide resolved
@michaelstaib
Copy link
Member

Do we have an integration test for this one?

@michaelstaib michaelstaib changed the title 🚧WIP🚧: Better support for EF Added support for IQueryable Projections Mar 6, 2020
michaelstaib
michaelstaib reviewed Mar 6, 2020
View reviewed changes
Copy link
Member

@michaelstaib michaelstaib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks very good. We just need to remove the resolver metadata as discussed on slack. As soon as you have done that I will merge this PR an start on the resource handling in the execution engine. Great work @PascalSenn.

@TheJayMann TheJayMann mentioned this pull request Mar 7, 2020
Closed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Mar 7, 2020

SonarCloud Quality Gate failed.

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 10 Code Smells

82.9% 82.9% Coverage
1.1% 1.1% Duplication

@michaelstaib michaelstaib merged commit 8302ae7 into version_10_0_0_master Mar 7, 2020
@michaelstaib michaelstaib deleted the feature_entity_framework branch March 7, 2020 22:04
This was referenced Mar 8, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheJayMann TheJayMann TheJayMann left review comments

@michaelstaib michaelstaib michaelstaib approved these changes

Assignees

@PascalSenn PascalSenn

Labels
None yet
Projects
None yet
Milestone
HC-10.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@PascalSenn @michaelstaib @TheJayMann