Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client overrides (logo, favicon, PWA icons) does't work behind Nginx #3292

Closed
kimsible opened this issue Nov 11, 2020 · 1 comment · Fixed by #3297
Closed

Client overrides (logo, favicon, PWA icons) does't work behind Nginx #3292

kimsible opened this issue Nov 11, 2020 · 1 comment · Fixed by #3297

Comments

@kimsible
Copy link
Contributor

kimsible commented Nov 11, 2020 •
edited
Loading

Client overrides logo, favicon, PWA icons seem to not work behind Nginx

#2897 (comment)
@Chocobozzz Chocobozzz added the Status: To Reproduce Likely a bug but needs reproduction and/or extended log from the issuer label Nov 12, 2020
@kimsible
Copy link
Contributor Author

After testing the new docker config with nginx it is caused by the assets optimization of Nginx that does not consider client-overrides :

PeerTube/support/nginx/peertube

Line 61 in b8fa244

location ~ ^/client/(.*\.(js|css|png|svg|woff2|otf|ttf|woff|eot))$ {

@kimsible kimsible changed the title Client overrides (logo, favicon, PWA icons) does't work behind Nginx or Traefik Client overrides (logo, favicon, PWA icons) does't work behind Nginx Nov 12, 2020
@kimsible kimsible mentioned this issue Nov 12, 2020
Merged
@rigelk rigelk removed the Status: To Reproduce Likely a bug but needs reproduction and/or extended log from the issuer label Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add client overrides to nginx configuration kimsible/PeerTube
3 participants
@kimsible @Chocobozzz @rigelk