add client overrides to nginx configuration

[kimsible]

Description

In production client-overrides don't work with nginx because client assets were bypassed without considering client-overrides handled in PeerTube.

Related issues

• Fix Client overrides (logo, favicon, PWA icons) does't work behind Nginx #3292
• Also fixes a the doc for a docker-compose command with multiples compose files.

Has this been tested?

I tested it with production scripts, it may need more tests ? @rigelk ?

[kimsible]

Hi @JohnXLivingston, this configuration of nginx works for you ?

[rigelk]

Why not merge the two with:

location ~ ^/client/assets/images/(logo\.svg|favicon\.png|icons/icon-(36x36|48x48|72x72|96x96|144x144|192x192|512x512)\.png)$

[kimsible]

@rigelk I've merged the rules with more explicit file names in the regexp, it's long but better, I think, to maintain.

[JohnXLivingston]

Hi @JohnXLivingston, this configuration of nginx works for you ?

It works... But it is no more dynamic... If files don't exist, it fails and there are missing icons. Or I'm I missing something? (I don't really know nginx syntax)

[kimsible]

Thanks @JohnXLivingston

It works... But it is no more dynamic..

Sorry I don't see what you mean by "dynamic", you mean nginx ?

If files don't exist, it fails and there are missing icons. Or I'm I missing something? (I don't really know nginx syntax)

What kind of failure ? The icons should not be missing if the dist client directory exists, would you make a screenshot or a copy of your error ?

[JohnXLivingston]

What kind of failure ? The icons should not be missing if the dist client directory exists, would you make a screenshot or a copy of your error ?

As I said, I'm not familiar with nginx configuration, perhaps I'm wrong. What happens if the try_files directive don't find the file? If it continues to the next «location ~»? In this case, my bad, it's ok.

[rigelk]

@kimsible thanks a lot for spotting and fixing the issue!

[JohnXLivingston]

Are the config key storage.client_overrides, the constant CLIENT_OVERRIDES_DIR and the associated code in server/controllers/client.ts still needed?

[kimsible]

@JohnXLivingston

Are the config key storage.client_overrides, the constant CLIENT_OVERRIDES_DIR and the associated code in server/controllers/client.ts still needed?

Yes, as not everybody uses nginx as a reverse proxy.