Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

title attribute is missing on <iframe> tag suggested for embedding #3861

Closed
lunar-debian opened this issue Mar 16, 2021 · 4 comments · Fixed by #3901
Closed

title attribute is missing on <iframe> tag suggested for embedding #3861

lunar-debian opened this issue Mar 16, 2021 · 4 comments · Fixed by #3901
Labels
Component: Accessibility good first issue Type: Feature Request ✨

Comments

@lunar-debian
Copy link

Describe the current behavior
When I want to embed a video in another webpage, the generated code contains an <iframe> tag without a title attribute. The latter being recommended for accessibility purposes.

Steps to reproduce:

  1. Open the page of a video.
  2. Click “Share”
  3. Click “Embed”

The generated HTML code is missing the title attribute in the <iframe> tag.

Describe the expected behavior
The title attribute should be set with the title of the video.

Additional information

This is probably a nice issue to be solved by newcomers. :)
@rigelk
Copy link
Collaborator

rigelk commented Mar 21, 2021 •
edited
Loading

hi! Thanks for spotting the issue!

I guess https://www.w3.org/TR/WCAG20-TECHS/H64.html is the recommendation you refer to?

@pthavarasa
Copy link
Contributor

Hi @rigelk,

I fixed this issue. Now there is a title in the iframe tag.
share video -> video title
share playlist -> playlist title
share playlist video(right click in the video to copy embed) -> video title

@rigelk
Copy link
Collaborator

rigelk commented Mar 29, 2021

@pthavarasa please submit a PR then

@pthavarasa
Copy link
Contributor

@rigelk i have no idea if i made a proper PR, can you help me please?

@rigelk rigelk linked a pull request Mar 30, 2021 that will close this issue
fix missing title attribute on <iframe> tag suggested for embedding #3901
Merged
Chocobozzz pushed a commit that referenced this issue Mar 31, 2021
@pthavarasa
fix missing title attribute on <iframe> tag suggested for embedding (#…
4097c6d 
…3901)

* title attribute is missing on <iframe> tag suggested for embedding #3861

* fix #3901

* fix: escapeHTML #3901

* fix: playlist title instead of video title #3901

* fix #3901

* assign title directly #3901
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Accessibility good first issue Type: Feature Request ✨
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix missing title attribute on <iframe> tag suggested for embedding
3 participants
@rigelk @lunar-debian @pthavarasa