Added 'total downloaded' from server and peers in the player #3394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements Chocobozzz#3384 This will only work with HLS. The display for Webtorrent is left untouched.
rigelk
requested changes
Dec 4, 2020
There was a problem hiding this comment.
Aside from some quirks, LGTM! Thanks for your contribution @Poslovitch!
rigelk
approved these changes
Dec 4, 2020
|
Thanks everyone! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements #3384 with the changes @Chocobozzz suggested in #3384 (comment). Namely:
sourcefield inPlayerNetworkInfosubDivWebtorrent.title(fromp2p-info-button.ts) if the server uses HLS.WebTorrent is seemingly not able to tell the difference between the server and other peers, hence why it's left out of that PR.
Related issues
Resolves #3384
Has this been tested?
Screenshots