Handle video file move in a job #4282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would #4290 fix the underlying issue? |
|
Yes, It'll solve a huge part of it. After the upload is done there's still a few kind of heavy operations that's done during the HTTP request
Hypothetically that can be an issue, but maybe it's better solve that when it's a real issue. |
👍 Then closing and we'll see when the S3 PR will be integrated |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is a proposal that shows how heavy tasks during file upload is handled in a job instead of during the HTTP request. This will make PeerTube scale better when an instance grows big and a lot of file uploads are done simultaneously. It will also create a better user experience since the user can leave the video creation before all the video process are done, which is not the case today. And it will also solve issues when using S3 video storage where it can take 10 minutes for a file move to S3 to finish.
@Chocobozzz Should I go further with this? Do you have any preferences regarding how it should be handled?
Related issues
#4147
#3661
Has this been tested?