Inform user to fill account profile and channels

[kimsible]

Description

This PR adds a modal and alerts to inform the user to set up the account profile and channels.

• display a modal when logged in to explain why and where set up the account profile
  • the modal won't display anymore when description and avatar are added
• display alerts to inform why and where set up channels on /my-library/video-channels, /my-library/video-playlists and /videos/upload
  • the alerts won't display anymore when description and avatar are added on all channels not fully completed

Related issues

Resolves #3331

Has this been tested?

• 🙅 no, because this PR does not update server code

Screenshots

[Chocobozzz]

Thanks!

[kimsible]

I forgot to add another screenshot for the account profile :

[kimsible]

Hi @Chocobozzz, I don't understand the goal of this commit bf80903 (Don't display account setup modal on signup, don't bother user with a modal just after signup) because it was intended to be a little more didactic with the user, it's a real pain for moderation to explain every time at most of user that an avatar and a description are indeed required to not be taken as a « phantom » or a bot account (lots of bots pass Captcha as you know).

Skipping this modal is also at the total opposite of the initial need : 8f58172.

I understand some instances may do not need the modal, a solution maybe to simply disable this modal in the server configuration ?

A discussion with the community should have been done here, lots of admins on opened registration instances have for sure an interesting feedback about that.

[Chocobozzz]

I don't understand the goal of this commit bf80903

The modal was displayed just after signup, hiding the welcome signup message. But it's still opened when the user refreshes the page.

I understand some instances may do not need the modal, a solution maybe to simply disable this modal in the server configuration?

We try to keep consistency in warning/welcome modal default behaviours, allowing users to skip it. If admins want a specific behaviour in modals, we can add plugin hooks/css classes or config if it's a common pattern for many instances.
But forcing every peertube user to fill an avatar, without any possibility to hide the modal will create frustration, that I will have to handle.

A discussion with the community should have been done here

You're free to open the discussion

[kimsible]

@Chocobozzz

If admins want a specific behaviour in modals, we can add plugin hooks/css classes or config if it's a common pattern for many instances.

Sorry, I should have implement it, maybe you could have mention it here when the PR was opened as we done constructively for this one #4336 ?

The modal was displayed just after signup, hiding the welcome signup message. But it's still opened when the user refreshes the page.

Only root have a welcome signup modal, sorry I didn't see any welcome signup message for regular users during development, would you show me where it is ?

But it's still opened when the user refreshes the page.

A single page application is not intended to be refreshed, but if you quit the browser and come back for the second time, so, it's not the first time anymore...

[Chocobozzz]

maybe you could have mention it here when the PR was opened

I did not realize that we were forced to fill these attributes when the PR was merged. It's the reason why I restored a more common behaviour, that could be redefined by admin in future commits/PRs.

would you show me where it is

This one https://github.com/Chocobozzz/PeerTube/blob/develop/client/src/app/%2Bsignup/shared/signup-success.component.html

[kimsible]

I did not realize that we were forced to fill these attributes when the PR was merged. It's the reason why I restored a more common behaviour, that can be redefined by admin in future commits.

Sorry, I wasn't clear then, I will be more in the future. Would you add a filter to disable the dismiss checkbox ?

This one https://github.com/Chocobozzz/PeerTube/blob/develop/client/src/app/%2Bsignup/shared/signup-success.component.html

This is weird, maybe an issue, this modal does not display at all. But a good solution to our problem would be to add a simple text in this modal about avatar / description of account profile ?

[kimsible]

@Chocobozzz if you do not plan to release today, I can propose something this afternoon to complete the welcome modal (and inspect if there is any issue why the modal does not display) and also a filter/hook.