feat(API): permissive email check in login, reset & verification #6648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontrollanten
force-pushed
the
feat-6570-permissive-email-handling
branch
2 times, most recently
from
77c4d9e to
4134f25
Compare
In order to not force users to be case sensitive when asking for password reset or resend email verification. When there's multiple emails where the only difference in the local is the capitalized letters, in those cases the users has to be case sensitive. closes Chocobozzz#6570
kontrollanten
force-pushed
the
feat-6570-permissive-email-handling
branch
from
4134f25 to
b417ca2
Compare
Allow case insensitive email when there's no other candidate. closes Chocobozzz#6570
kontrollanten
force-pushed
the
feat-6570-permissive-email-handling
branch
from
b417ca2 to
5e44b71
Compare
kontrollanten
changed the title
4 tasks
Chocobozzz
requested changes
Jan 14, 2025
|
@Chocobozzz Your comments are resolved. But now some of the new tests fails since the email exists check is case insensitive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to not force users to be case sensitive when asking for password reset or resend email verification. When there's multiple emails where the only difference in the local is the capitalized letters, in those cases the users has to be case sensitive.
Related issues
closes #6570
Has this been tested?
Screenshots