-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct evaluation of HTML custom properties and JSON support #1001
Conversation
Thanks! This will need unit tests for the new function you added and some e2e tests for each input type. It looks like you need to run the linter as well. |
@brosua are you still interested in getting this merged? |
Yes, I will try to update the MR this week |
Hello @mtriff , you can check the updated MR. |
awaiting this, really need the functionality, thanks for fixing it :) |
awaiting this pr |
Awaiting this PR, please review and merge. |
Hello all, sorry for the long delay in getting this merged. I'd like to get this into the next release as well! Taking a look at the branch, it still needs an e2e test. I've been testing it out locally and it looks like JSON custom properties breaks search with Fuse.js (errors in the console). It looks like this might be fixed by upgrading dependencies, but I haven't had a chance to look into it further. |
Thank you for the contribution @brosua! |
Description
The data attribute was mispelled. Also I added a logic to parse JSON, if multiple custom attributes have to be added.
It fixes #982.
Screenshots (if appropriate)
Types of changes
Checklist