Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fix support for non-Latin characters #1072

Merged
merged 6 commits into from
Nov 29, 2022
Merged

[BUGFIX] Fix support for non-Latin characters #1072

merged 6 commits into from
Nov 29, 2022

Conversation

ousmorez
Copy link
Contributor

Description

I've added some more characters to the dropdown opener in the regex, so that the dropdown opens when the following keys are pressed on the keyboard:
MacTigr-thumb-top
Because if those characters are available to type, they can open the drop-down menu after pressing.
Also correct first character when trying to type numbers or non-English.

it solves following bug:

#1068

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • I have added new tests for the bug I fixed/the new feature I added.
  • I have modified existing tests for the bug I fixed/the new feature I added.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

src/scripts/choices.ts Outdated Show resolved Hide resolved
src/scripts/choices.ts Show resolved Hide resolved
@mtriff mtriff added the changes required Pull request requires changes before it can be merged label Nov 17, 2022
mtriff
mtriff previously approved these changes Nov 19, 2022
@ousmorez
Copy link
Contributor Author

ousmorez commented Nov 20, 2022

I checked the error in the pipeline and found that the problem is solved if the following packages are installed:

  "pixelmatch": "^5.3.0",
  "puppeteer": "^19.2.2",

We need to add these packages to package.json.
This has nothing to do with my changes, should I add these packages?
@mtriff

@ousmorez ousmorez reopened this Nov 27, 2022
محمدرضا ضربی زاده added 2 commits November 28, 2022 14:51
@ousmorez
Copy link
Contributor Author

I can't resolve the failed checks, can you please help me?
@mtriff

@mtriff mtriff added bugfix Pull request that fixes an existing bug and removed changes required Pull request requires changes before it can be merged labels Nov 29, 2022
@mtriff mtriff changed the title Wrong character when using non-English keyboard [BUGFIX] Fix support for non-Latin characters Nov 29, 2022
@mtriff mtriff merged commit 312971a into Choices-js:master Nov 29, 2022
@mtriff
Copy link
Member

mtriff commented Nov 29, 2022

Thanks so much for the contribution @ousmorez!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants