-
Notifications
You must be signed in to change notification settings - Fork 618
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Fix support for non-Latin characters #1072
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtriff
reviewed
Nov 17, 2022
mtriff
added
the
changes required
Pull request requires changes before it can be merged
label
Nov 17, 2022
mtriff
previously approved these changes
Nov 19, 2022
I checked the error in the pipeline and found that the problem is solved if the following packages are installed: "pixelmatch": "^5.3.0",
"puppeteer": "^19.2.2", We need to add these packages to |
I can't resolve the failed checks, can you please help me? |
mtriff
added
bugfix
Pull request that fixes an existing bug
and removed
changes required
Pull request requires changes before it can be merged
labels
Nov 29, 2022
mtriff
changed the title
Wrong character when using non-English keyboard
[BUGFIX] Fix support for non-Latin characters
Nov 29, 2022
mtriff
approved these changes
Nov 29, 2022
Thanks so much for the contribution @ousmorez! |
2 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've added some more characters to the dropdown opener in the regex, so that the dropdown opens when the following keys are pressed on the keyboard:
Because if those characters are available to type, they can open the drop-down menu after pressing.
Also correct first character when trying to type numbers or non-English.
it solves following bug:
#1068
Types of changes
Checklist