Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tab => direction keys handling with disabled search #1260

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Fix tab => direction keys handling with disabled search #1260

merged 1 commit into from
Feb 3, 2025
+41 −12

Conversation

zoglo
Copy link
Contributor

@zoglo zoglo commented Feb 2, 2025

Description

This is a continuation of #1242

Whilst the PR in #1242 did work, we forgot the case that a choices may not have an input field when the search is disabled.
Without a search input, we are not closing the dropdown if it has been open when tabbing away.

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • I have added new tests for the bug I fixed/the new feature I added.
  • I have modified existing tests for the bug I fixed/the new feature I added.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@zoglo zoglo mentioned this pull request Feb 2, 2025
Merged
leofeyer pushed a commit to contao-components/choices that referenced this pull request Feb 3, 2025
@zoglo
Fix tab => direction keys handling with disabled search (see #6)
9a5d73e 
Description
-----------

### Description

Supersedes the temporary hotfix contao/contao#7978
This provides the bugfix where tabbing away would not close the dropdown if we do not have the search enabled.

Already opened a PR within choices Choices-js/Choices#1260

Commits
-------

527cbaf Fix `tab` => direction keys handling with disabled search
Xon
Xon approved these changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@Xon Xon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Xon Xon added the bugfix Pull request that fixes an existing bug label Feb 3, 2025
@Xon Xon merged commit eee6be6 into Choices-js:main Feb 3, 2025
10 checks passed
@zoglo zoglo deleted the fix/close-dropdown-search-disabled branch February 3, 2025 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xon Xon Xon approved these changes

Assignees
No one assigned
Labels
bugfix Pull request that fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zoglo @Xon