fix unhighlightAll performance issue #648
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Due to an error in a condition, hasHighlightedItems variable is assigned an array and the condition below is always true. As a result, unhighlightAll is called each time, which updates items that need to be rendered again.
Motivation and Context
When using Formio.js with large number of select components performance issue was noticed.
For every click and keypress in any component items of all select components are rendered.
How Has This Been Tested?
Tested locally in Formio.js
After this fix unhighlightAll and _render are not called on every click
Types of changes
Checklist: