Made IE11 scrollbar check more precise (updated) (fixes #621) #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tinovyatkin
suggested changes
Oct 27, 2019
Comment on lines
+1407
to
+1410
| // ... but the click was on the right side of the items... | ||
| const firstItem = this.choiceList.getChild( | ||
| `.${this.config.classNames.item}`, | ||
| ); |
There was a problem hiding this comment.
@sebastianhaberey This library support RTL, so, we need to check here this._direction and use either left or right.
Currently, while using default templates, scrollbar is always on the right side, but it will be fixed by #711 or may be overriden by custom template.
jshjohnson
added
the
enhancement
8 tasks
jshjohnson
pushed a commit
that referenced
this pull request
Nov 12, 2019
* scope onMouseDown event capture * supercedes #710 * make isIE11 a const * scope keydown * scope mouseover * fix removeEventListener for keyup
|
This has been superseded by #740 :) thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated #625 to match current master.
This is just the fix in the source code. To ensure effortless merging, I didn't rebuild the assets here.