Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve bug 533 #736

Merged
merged 18 commits into from
Nov 3, 2019
Merged

Resolve bug 533 #736

merged 18 commits into from
Nov 3, 2019

Conversation

jshjohnson
Copy link
Collaborator

@jshjohnson jshjohnson commented Nov 3, 2019

Description

Implements suggested fix by @tinovyatkin (#571)

Screenshots (if appropriate)

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@codecov
Copy link

codecov bot commented Nov 3, 2019

Codecov Report

Merging #736 into master will increase coverage by 0.1%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #736     +/-   ##
=========================================
+ Coverage   66.53%   66.64%   +0.1%     
=========================================
  Files          22       22             
  Lines        1306     1307      +1     
=========================================
+ Hits          869      871      +2     
+ Misses        437      436      -1
Impacted Files Coverage Δ
src/scripts/choices.js 54.4% <66.66%> (+0.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab22347...4384a08. Read the comment docs.

@jshjohnson jshjohnson merged commit f30b976 into master Nov 3, 2019
@jshjohnson jshjohnson added the bugfix Pull request that fixes an existing bug label Nov 3, 2019
@jshjohnson jshjohnson deleted the resolve-bug-533 branch November 3, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes an existing bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant