Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation of input type terms #873

Merged
merged 2 commits into from
Dec 19, 2021
Merged

Conversation

trbroyles1
Copy link
Contributor

Description

Add a table with documentation of HTML5 input tag correspondence to terms used in Choices documentation. Clarifies input element requirements for Choices behavior.
May help others who experience issues similar to #872

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Add a table with documentation of HTML5 input tag correspondence to terms used in Choices documentation
Clean up typos, simplify table and use MDN for reference links
Copy link
Member

@mtriff mtriff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really nice! I've just made some changes to fix typos, simplify the table and use MDN as a reference instead. This should be a helpful addition to the docs 😃.

@mtriff mtriff added the documentation Pull request that changes documentation label Dec 19, 2021
@mtriff mtriff merged commit 8647f36 into Choices-js:master Dec 19, 2021
@Xon Xon mentioned this pull request Aug 22, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull request that changes documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants