Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trigger search when clearing the input field with search floor of 0 #992

Merged
merged 2 commits into from
Jan 1, 2022
Merged

Trigger search when clearing the input field with search floor of 0 #992

merged 2 commits into from
Jan 1, 2022

Conversation

mtriff
Copy link
Member

@mtriff mtriff commented Jan 1, 2022 •
edited
Loading

Description

Continuation of #854. Trigger search when clearing the input field with search floor of 0.

Closes #630

Screenshots (if appropriate)

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • I have added new tests for the bug I fixed/the new feature I added.
  • I have modified existing tests for the bug I fixed/the new feature I added.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mtriff mtriff added the bugfix Pull request that fixes an existing bug label Jan 1, 2022
@mtriff mtriff merged commit 7758226 into master Jan 1, 2022
@mtriff mtriff mentioned this pull request Jan 1, 2022
Closed
8 tasks
@mtriff mtriff deleted the searchfloor0 branch January 12, 2022 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bugfix Pull request that fixes an existing bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

allow triggering of 'search' event when clearing the input field
1 participant
@mtriff