Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: background integration #64

Merged
merged 10 commits into from
Jan 27, 2025
Merged

Conversation

sonkeydotcom
Copy link
Contributor

close #46

Copy link
Contributor

@jsandinoDev jsandinoDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Problem with font color of header after click tooggle button
  • Background color still the same
Screenshot 2025-01-23 at 6 51 01 PM

@jsandinoDev
Copy link
Contributor

When you fix that, can you please add an screenshot of the home screen?

@sonkeydotcom
Copy link
Contributor Author

Screen Shot 2025-01-24 at 1 58 30 AM
Screen Shot 2025-01-24 at 1 58 42 AM

@jsandinoDev
Copy link
Contributor

jsandinoDev commented Jan 24, 2025

@sonkeydotcom Pretty good but, Can you keep the original color for the dark theme of the app? And for the light theme can you use #dbd9d9 (it is a white but not that bright)

@sonkeydotcom
Copy link
Contributor Author

its done

Copy link
Contributor

@jsandinoDev jsandinoDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsandinoDev jsandinoDev requested a review from Ilialtes January 24, 2025 01:17
@@ -16,7 +16,7 @@ const Home: NextPage = () => {

return (
<>
<div className="relative flex justify-center items-center min-h-screen text-white overflow-hidden">
<div className="relative flex justify-center items-center min-h-scree overflow-hidden">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

min-h-scree?

const isDarkMode = theme === "dark";

const toggleMode = () => {
// const newMode = isDarkMode ? "light" : "dark";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove unused comments

@@ -2,7 +2,7 @@ import React from "react";

const StarryBackground = () => {
return (
<div className="absolute inset-0 bg-gradient-to-b from-[#243B55] to-[#141E30] overflow-hidden">
<div className="absolute inset-0 overflow-hidden"> {/* bg-gradient-to-b from-[#243B55] to-[#141E30] */}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments

@@ -40,6 +40,7 @@ p {
filter: blur(229px);
position: absolute;
top: 0;
display: none /* Hidden */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments

@@ -49,6 +50,7 @@ p {
position: absolute;
top: 0;
right: 0;
display: none /* Hidden */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments

@@ -100,6 +102,7 @@ p {
border-radius: 630px;
background: #7353d2;
filter: blur(229px);
display: none /* Hidden */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments

@@ -109,6 +112,7 @@ p {
position: absolute;
top: 0;
right: 0;
display: none /* Hidden */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@jsandinoDev jsandinoDev requested a review from Ilialtes January 25, 2025 03:47
Copy link
Contributor

@Ilialtes Ilialtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ilialtes Ilialtes merged commit f0e0514 into Chonete-Builders:main Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Add toogle for ligth and dark theme management
3 participants