-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: background integration #64
Conversation
Signed-off-by: superman <[email protected]>
Signed-off-by: superman <[email protected]>
Signed-off-by: superman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When you fix that, can you please add an screenshot of the home screen? |
@sonkeydotcom Pretty good but, Can you keep the original color for the dark theme of the app? And for the light theme can you use #dbd9d9 (it is a white but not that bright) |
Signed-off-by: superman <[email protected]>
its done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
packages/nextjs/app/page.tsx
Outdated
@@ -16,7 +16,7 @@ const Home: NextPage = () => { | |||
|
|||
return ( | |||
<> | |||
<div className="relative flex justify-center items-center min-h-screen text-white overflow-hidden"> | |||
<div className="relative flex justify-center items-center min-h-scree overflow-hidden"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
min-h-scree?
const isDarkMode = theme === "dark"; | ||
|
||
const toggleMode = () => { | ||
// const newMode = isDarkMode ? "light" : "dark"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove unused comments
@@ -2,7 +2,7 @@ import React from "react"; | |||
|
|||
const StarryBackground = () => { | |||
return ( | |||
<div className="absolute inset-0 bg-gradient-to-b from-[#243B55] to-[#141E30] overflow-hidden"> | |||
<div className="absolute inset-0 overflow-hidden"> {/* bg-gradient-to-b from-[#243B55] to-[#141E30] */} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comments
packages/nextjs/styles/globals.css
Outdated
@@ -40,6 +40,7 @@ p { | |||
filter: blur(229px); | |||
position: absolute; | |||
top: 0; | |||
display: none /* Hidden */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comments
packages/nextjs/styles/globals.css
Outdated
@@ -49,6 +50,7 @@ p { | |||
position: absolute; | |||
top: 0; | |||
right: 0; | |||
display: none /* Hidden */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comments
packages/nextjs/styles/globals.css
Outdated
@@ -100,6 +102,7 @@ p { | |||
border-radius: 630px; | |||
background: #7353d2; | |||
filter: blur(229px); | |||
display: none /* Hidden */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comments
packages/nextjs/styles/globals.css
Outdated
@@ -109,6 +112,7 @@ p { | |||
position: absolute; | |||
top: 0; | |||
right: 0; | |||
display: none /* Hidden */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Signed-off-by: superman <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
close #46