-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Created a modal that explains the game rules #74
Conversation
Signed-off-by: RareMmemshima <[email protected]>
Signed-off-by: RareMmemshima <[email protected]>
Signed-off-by: RareMmemshima <[email protected]>
Signed-off-by: RareMmemshima <[email protected]>
Signed-off-by: RareMmemshima <[email protected]>
> | ||
<div | ||
className="modal-box modal-border bg-modal rounded-[8px] border flex flex-col gap-3 justify-around relative " | ||
onClick={(e) => e.stopPropagation()} // Prevent click propagation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove comments
export const CoinflipPage = () => { | ||
|
||
|
||
const tips = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add tips const to the CONST file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolve comments
Signed-off-by: RareMmemshima <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
</div> | ||
|
||
|
||
<Modal isOpen={isModalOpen} onClose={closeModal}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Move the modal component into a new component to keep it re-usable for future implementations
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i dont think that would be necessary, there is already modal, i just created this to fit the purpose of what i was doing there
Signed-off-by: RareMmemshima <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
closes #50