Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Created a modal that explains the game rules #74

Merged
merged 9 commits into from
Jan 29, 2025

Conversation

RareMmemshima
Copy link
Contributor

closes #50

>
<div
className="modal-box modal-border bg-modal rounded-[8px] border flex flex-col gap-3 justify-around relative "
onClick={(e) => e.stopPropagation()} // Prevent click propagation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove comments

export const CoinflipPage = () => {


const tips = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add tips const to the CONST file

Copy link
Contributor

@jsandinoDev jsandinoDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve comments

Copy link
Contributor

@jsandinoDev jsandinoDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsandinoDev jsandinoDev requested a review from Ilialtes January 28, 2025 18:07
</div>


<Modal isOpen={isModalOpen} onClose={closeModal}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move the modal component into a new component to keep it re-usable for future implementations

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think that would be necessary, there is already modal, i just created this to fit the purpose of what i was doing there

Copy link
Contributor

@Ilialtes Ilialtes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Ilialtes Ilialtes merged commit 22123bc into Chonete-Builders:main Jan 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] Create a modal that explains the game rules when a user clicks on a "How to Play" button.
3 participants