-
-
Notifications
You must be signed in to change notification settings - Fork 135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
README reworked #369
README reworked #369
Conversation
README.md
Outdated
<p align="center"> | ||
It's a dialer but it's simple and it looks pretty good honestly | ||
A dialer, but simple and looks pretty good honestly |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO the old short_description we used (initially added by izzy) is a better one.
uniquely stylized phone app with customizable features
(https://github.com/Chooloo/koler/blob/master/fastlane/metadata/android/en-US/short_description.txt)
We do currently using that for F-Droid as well. See here
What do you think @roeiedri & @comradekingu
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that short_desc is too long for the new guidelines(?). "Dialer" should be included.
Here, the repeated "it's" has me irked.
Tried shortening it.
Co-authored-by: Van Nghia <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A dialer, but it's simple and looks pretty good honestly
I think an exclamation at the end of the sentance would make it a bit more enthusiastic and overall looks better. Other than that, This is a great change. Should be merged.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are better at this than me
No description provided.