Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README reworked #369

Merged
merged 4 commits into from
Jun 19, 2023
Merged

README reworked #369

merged 4 commits into from
Jun 19, 2023

Conversation

comradekingu
Copy link
Contributor

No description provided.

README.md Outdated
<p align="center">
It's a dialer but it's simple and it looks pretty good honestly
A dialer, but simple and looks pretty good honestly
Copy link
Contributor

@shuvashish76 shuvashish76 Mar 19, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO the old short_description we used (initially added by izzy) is a better one.

uniquely stylized phone app with customizable features
(https://github.com/Chooloo/koler/blob/master/fastlane/metadata/android/en-US/short_description.txt)

We do currently using that for F-Droid as well. See here

What do you think @roeiedri & @comradekingu

Copy link
Contributor Author

@comradekingu comradekingu Apr 15, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that short_desc is too long for the new guidelines(?). "Dialer" should be included.

Here, the repeated "it's" has me irked.
Tried shortening it.

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Co-authored-by: Van Nghia <[email protected]>
Copy link

@Chefski Chefski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A dialer, but it's simple and looks pretty good honestly

I think an exclamation at the end of the sentance would make it a bit more enthusiastic and overall looks better. Other than that, This is a great change. Should be merged.

README.md Outdated Show resolved Hide resolved
Copy link
Collaborator

@roeiedri roeiedri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are better at this than me

@roeiedri roeiedri changed the base branch from master to staging June 19, 2023 20:17
@roeiedri roeiedri merged commit a800601 into Chooloo:staging Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants