[MicroWin] Don't disable already disabled features #2675
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
Type of Change
Description
This PR excludes features that are already disabled in the image. It's nothing but a timesaver, especially for less powerful systems:
EDIT: Some (raw) benchmarks of the latest version and the one with this change:
The benchmarks were performed on a dual-core system, with a couple of applications running. The time taken was measured manually. These values are subject to change depending on your hardware or software configuration.
Testing
Testing was performed on a Windows 11 23H2 image and concluded with no issues. No differences were present across the current method and this one after grabbing the feature listings. Below are the actual differences of both reports:
experimental_features_report.md
contains feature listings of a Windows image after running a MicroWin experiment with package listings reversed, but with no changes to feature disablementtimesaver_features_report.md
contains feature listings of a Windows image after running this changeImpact
Less time to be spent disabling features
Issue related to PR
None
Additional Information
No documentation changes were necessary, but please test this for any issues present that I may not know of
Checklist