-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config file validation #2762
Config file validation #2762
Conversation
- applications.json - preset.json
How does this work? |
It checks whether config files match the structure of the JSON schemas. And if they do not, VS Code reports errors. Also, if a user presses Here's an official site of a JSON schema. |
Make sure to update docs for if this is merged so people know. |
Does this mean, winutil will become dependent on the third-party Github Repo SchemaStore for Autocompletion (e.g. If we want to add to the Schema[autocompletion], we are at the mercy of the Maintainer of SchemaStore to merge the Update PR) or am I missing something here? |
Can we add files somewhere in the repo instead of hosting it on SchemaStore? |
In the current implementation id does. But the way this completion is provided can be changed: I can put such schemas right here, in this repository. It's worth to note that I've just placed schemas to SchemaStore initially because I'm relatively well-known contributor there and my PRs are relatively quickly accepted. 😄 However, I share your feelings about SchemaStore. And I'll move schemas here.
Yes, we can. It's technically possible. I just have to put schemas here and map them to validated JSON files (like I did with remote schemas). |
I like this idea. Can wait to see what other changes you bring. I'd like to see what you do with themes.json. |
I think this was aleady tried out once with a local scheme in #2532 and closed out. Correct me if I'm wrong or did not understand it. |
Type of Change
Description
Provides completion and validation for some config files in a JSON format.
Features:
Testing
Testing has been performed in SchemaStore project.
Impact
Issue related to PR
Additional Information
VS Code code pulls schemas from a SchemaStore schema catalog in the background
according to .vscode/settings.json file and provides completion and
validation.
Checklist