Skip to content

Commit

Permalink
[ui] Fix <devtools-toolbar> height computation.
Browse files Browse the repository at this point in the history
Put the `--toolbar-height` onto the content element rather than the host
element, as otherwise the bottom border will be within the height.

Fixed: 390588608
Bug: 388445687
Change-Id: I5bb8c563e9b4b528dfdb2bf46cd415441fe0c458
Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/6177751
Auto-Submit: Benedikt Meurer <[email protected]>
Reviewed-by: Alex Rudenko <[email protected]>
Commit-Queue: Benedikt Meurer <[email protected]>
  • Loading branch information
bmeurer authored and Devtools-frontend LUCI CQ committed Jan 17, 2025
1 parent bb93096 commit 0b1cb37
Showing 1 changed file with 4 additions and 4 deletions.
8 changes: 4 additions & 4 deletions front_end/ui/legacy/toolbar.css
Original file line number Diff line number Diff line change
Expand Up @@ -17,10 +17,6 @@
--toolbar-height: 26px;
}

:host(:not([floating], [wrappable])) {
height: var(--toolbar-height);
}

:host([floating]) {
flex-direction: column;
inset: 0;
Expand All @@ -38,3 +34,7 @@
flex-wrap: wrap;
overflow: visible;
}

slot {
height: var(--toolbar-height);
}

0 comments on commit 0b1cb37

Please sign in to comment.