Fix serilog installation. #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wparad
force-pushed
the
fix-serilog-installation
branch
from
e413c3e to
83c036a
Compare
|
We are having exactly the problem mentioned. I found out that:
uses an implicit Serilog 2.0.0. Bumping it to 4.0.0 would do the job but using explicit Serilog dependency seems like a better approach. Can we please merge it? :) |
thoean
approved these changes
Apr 11, 2024
|
Sorry this took a while - I've switched Email accounts and Github notifications went to the void for a bit... you should be all set now. https://www.nuget.org/packages/Serilog.Sinks.AwsCloudWatch/4.2.25 |
|
Thanks @thoean |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the dependent version of Serilog are incorrect, we must use 3.0.0+, but it isn't pulled in. Which pulls in 2, which has a different signature.