Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: allow chunk_overlap with zero value #457

Merged
merged 2 commits into from
Nov 5, 2024
Merged

fix: allow chunk_overlap with zero value #457

merged 2 commits into from
Nov 5, 2024

Conversation

pvl
Copy link
Contributor

@pvl pvl commented Nov 2, 2024

Description

Type of change

  • New features (non-breaking change).
  • Bug fix (non-breaking change).
  • Breaking change (fix or feature that would cause existing functionality not to work as expected).

Checklist

  • [X ] I have performed a self-review of my code.
  • I have added thorough tests if it is a core feature.
  • There is a reference to the original bug report and related work.
  • I have commented on my code, particularly in hard-to-understand areas.
  • The feature is well documented.

@pvl pvl changed the title allow chunk_overlap with zero value fix: allow chunk_overlap with zero value Nov 2, 2024
@taprosoft taprosoft merged commit 908452c into Cinnamon:main Nov 5, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] It is not possible to disable chunk overlap by setting a value of zero
2 participants
@pvl @taprosoft