Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updates submodule for multiple parent support #73

Closed
wants to merge 2 commits into from
Closed

updates submodule for multiple parent support #73

wants to merge 2 commits into from

Conversation

JalexChen
Copy link

@JalexChen JalexChen commented Apr 20, 2022 •
edited
Loading

Closes #52

@JalexChen JalexChen requested review from a team and FelicianoTech as code owners April 20, 2022 18:20
@JalexChen JalexChen closed this Apr 20, 2022
@JalexChen JalexChen reopened this Apr 20, 2022
EricRibeiro
EricRibeiro approved these changes Apr 25, 2022
View reviewed changes
Copy link

@EricRibeiro EricRibeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

FelicianoTech
FelicianoTech suggested changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@FelicianoTech FelicianoTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This just updated the submodule itself. We need to include changes to the manifest file as the Dockerfile template.

@JalexChen JalexChen mentioned this pull request Apr 25, 2022
Merged
@JalexChen JalexChen closed this Apr 27, 2022
@FelicianoTech FelicianoTech deleted the update-submodule branch August 26, 2022 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FelicianoTech FelicianoTech FelicianoTech requested changes

@EricRibeiro EricRibeiro EricRibeiro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for other Erlang versions
3 participants
@JalexChen @FelicianoTech @EricRibeiro