Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document behavior of duplicate parameter keys #3

Merged
merged 1 commit into from
Dec 2, 2022

Conversation

neeasade
Copy link
Contributor

Documenting the conversion behavior that happens when transforming to a dict here so we can rely on it elsewhere without it being an implementation detail.

  • 💭 Do we want to support this explicitly?

Documenting the conversion behavior that happens when transforming to a `dict` [here](https://github.com/CircleCI-Public/path-filtering-orb/blob/712b70dba289e8c4e2a737e00cea10e7038d1962/src/scripts/create-parameters.py#L61) so we can rely on it elsewhere without it being an implementation detail. 

- 💭  Do we want to support this explicitly?
@elliotforbes elliotforbes merged commit c851f6d into CircleCI-Public:main Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants