Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rework internals, fix a discovered bug ,export some utility functions #112

Merged
merged 4 commits into from
Oct 26, 2021
Merged

rework internals, fix a discovered bug ,export some utility functions #112

merged 4 commits into from
Oct 26, 2021

Conversation

vlandau
Copy link
Member

@vlandau vlandau commented Oct 26, 2021

This PR:

  • Reworks some internals to make use of utility functions to avoid code repetition
    • And two of those functions missingarray and missingarray_to_array are now exported with docstrings
  • Moves the function that solvers for current flow using Circuitscape to Circuitscape itself
  • Fixes a bug where inputs for conditional connectivity were only being properly formatted when using the INI method of run_omniscape (everything is now consistent for both methods)

@vlandau
Copy link
Member Author

vlandau commented Oct 26, 2021

Currently waiting on Circuitscape patch release to be merged to the registry

@vlandau vlandau merged commit 80fdfbf into main Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vlandau