Disable all typographic replacements in markdown renderer (go-gitea#1…

…1871) * Disable all typographic replacements in markdown renderer Previously we only disabled some of them. This disables all the default replacements that goldmark's typographer extension offers, matching GitHub's renderer. Ref: https://github.com/yuin/goldmark#typographer-extension Fixes: go-gitea#11001 * remove typographer extension completely * fix test * really fix test Co-authored-by: Lauris BH <[email protected]> Co-authored-by: techknowlogick <[email protected]>
CirnoT · Jun 13, 2020 · 2447ffc · 2447ffc
1 parent b6adf80
commit 2447ffc
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 8 deletions.
diff --git a/modules/markup/html_test.go b/modules/markup/html_test.go
@@ -208,7 +208,7 @@ func TestRender_email(t *testing.T) {
 	// Test that should *not* be turned into email links
 	test(
 		"\"[email protected]\"",
-		`<p>“[email protected]”</p>`)
+		`<p>&#34;[email protected]&#34;</p>`)
 	test(
 		"/home/gitea/mailstore/info@gitea/com",
 		`<p>/home/gitea/mailstore/info@gitea/com</p>`)

diff --git a/modules/markup/markdown/markdown.go b/modules/markup/markdown/markdown.go
@@ -49,13 +49,6 @@ func render(body []byte, urlPrefix string, metas map[string]string, wikiMarkdown
 				extension.TaskList,
 				extension.DefinitionList,
 				common.FootnoteExtension,
-				extension.NewTypographer(
-					extension.WithTypographicSubstitutions(extension.TypographicSubstitutions{
-						extension.EnDash:   nil,
-						extension.EmDash:   nil,
-						extension.Ellipsis: nil,
-					}),
-				),
 				meta.Meta,
 			),
 			goldmark.WithParserOptions(