-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Regressions? Glitches/crashes when initial picker display includes contacts #48
Comments
Can you try with the latest develop branch and let me know if the issue still occurs there? I need to cut a release to master and CocoaPods, I'll go ahead and do so if we can confirm the bug is fixed there. |
I switched to your develop branch, and still get the crash:
When the view initially tries to display with the picker containing three contacts over two lines:
|
@brunchboy Thanks for the info. I've think I've tracked down the cause of the bug, I hope to have a PR up shortly. |
This had been working before, but as of tonight (using the master branch), when our picker is set up to contain contacts during the initial display of the view which contains it, they do not display properly. I suspect this may be due to the new approach to handling an empty prompt. Indeed, a quick test confirms that these problems go away if I leave the prompt at its default value of
To:
but occur when setting it to the empty string.With a single contact present, the picker appears empty. But clicking on the right edge of the picker places the insertion point to the right of where the invisible contact should be. Trying to click on that invisible contact places the insertion point at the beginning of the line (leftmost edge of the picker). And trying to backspace over the invisible contact results in a crash:
With three initial contacts present, taking more than one line, the initial rendering of the view crashes as follows:
The text was updated successfully, but these errors were encountered: