Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/fix #48 #50

Merged
merged 2 commits into from
Jan 15, 2014
Merged

Feature/fix #48 #50

merged 2 commits into from
Jan 15, 2014

Conversation

mhupman
Copy link
Member

@mhupman mhupman commented Jan 15, 2014

Potential fix for #48

mhupman added 2 commits January 15, 2014 10:50
Fix bugs related to setting MBContactCollectionView.prompt or MBConta…
44dbfb0 
…ctCollectionView.showPrompt before a -[UICollectionView reloadData] has been invoked (either explicitly or implicitly).
whitespace
1d7423e
@ghost ghost assigned MattCBowman Jan 15, 2014
@brunchboy
Copy link

This does fix the crash and invisible contents, but it does not remove the space the prompt cell takes up (see attached screenshot):
ios simulatorscreensnapz001

@mhupman
Copy link
Member Author

mhupman commented Jan 15, 2014

In order to disable the prompt, you should use the new MBContactPicker.showPrompt field and set it to NO. Setting MBContactPicker.prompt == @"" no longer disables the prompt cell. Otherwise, you still end up with a prompt cell, which has a minimum width of 20 points in order to provide padding around the prompt text.

@mhupman
Copy link
Member Author

mhupman commented Jan 15, 2014

To clarify, showPrompt was added in #45.

@brunchboy
Copy link

Ah ha! With the adoption of this new property, this branch appears to be working as desired.

@mhupman
Copy link
Member Author

mhupman commented Jan 15, 2014

Good to hear! I'll merge this in and cut a new release.

mhupman added a commit that referenced this pull request Jan 15, 2014
@mhupman
Merge pull request #50 from Citrrus/feature/fix_#48
7a3d40d 
Feature/fix #48
@mhupman mhupman merged commit 7a3d40d into develop Jan 15, 2014
@mhupman mhupman deleted the feature/fix_#48 branch January 15, 2014 18:40
@brunchboy
Copy link

Sounds good! I have a couple issues I am working on opening, but I don’t think they are worth holding up your release; they are appearance issues which have been around since before this batch of enhancements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MattCBowman MattCBowman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mhupman @brunchboy @MattCBowman