Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-X Media edit button #273

Merged
merged 3 commits into from
Mar 6, 2024
Merged

UHF-X Media edit button #273

merged 3 commits into from
Mar 6, 2024

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Mar 6, 2024 •
edited by teroelonen
Loading

What was done

  • Added an edit button for media-library-item template.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT Admin theme
    • composer require drupal/hdbt_admin:dev-UHF-X_media_edit_button
  • Run make drush-cr

How to test

  • Check that the media entity fields have edit buttons
    image
  • Check that code follows our standards

teroelonen
teroelonen approved these changes Mar 6, 2024
View reviewed changes
Copy link
Contributor

@teroelonen teroelonen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works nicely 🦖

@khalima khalima merged commit b39cc0c into main Mar 6, 2024
1 check passed
@khalima khalima deleted the UHF-X_media_edit_button branch March 6, 2024 12:26
This was referenced Mar 6, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teroelonen teroelonen teroelonen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@khalima @teroelonen