Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-11275 Navigation toggle #1158

Merged
merged 3 commits into from
Jan 14, 2025
Merged

UHF-11275 Navigation toggle #1158

merged 3 commits into from
Jan 14, 2025

Conversation

khalima
Copy link
Contributor

@khalima khalima commented Jan 14, 2025

UHF-11275

What was done

  • Fixed the navigation toggle functionality for non-core sites.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-11275
  • Run make drush-cr

How to test

  • Check that there are no errors like below when clicking on mobile menu buttons in non-core sites
    image
  • Check that the branding buttons works normally in core-sites. If you're in a hurry, check at least "Rekry". ☺️
    image
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Copy link

⚠️ Visual regression found! Please check if this change is wanted or accidental. You can check the output here: https://city-of-helsinki.github.io/drupal-hdbt-visual-regression/pull/1158/html_report/

Copy link
Contributor

@annadruid annadruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants