Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-11396: Set error label level to 3 by default #1174

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Feb 4, 2025

UHF-11396

What was done

  • Set error label level to 3 by default
  • Fix the shade of gray in some of the cookie compliance elements.

How to install

  • Make sure your instance is up and running on latest dev branch.
    • git pull origin dev
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-11396
  • Run make drush-cr

How to test

  • Check that on the React searches the error message displayed uses aria-level=3 now instead of aria-level=2. You can easily get the error message visible on any React search by editing the ResultsContainer.tsx and copy-paste the <ResultsContainer> element with its content to the successful return and change the error message to some string like 'error' and then compile the theme.
  • Also check that if you don't agree to cookies and view the Askem element it should have #f2f2f2 background color. Same goes to the PowerBI embed block if you view it without agreeing to cookies.
  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

…ay in some of the cookie compliance elements
Copy link
Contributor

@annadruid annadruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants