Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-11098: Fix layout issues on job listing search after hds 4.1.0 update #660

Merged
merged 1 commit into from
Jan 23, 2025
Merged

UHF-11098: Fix layout issues on job listing search after hds 4.1.0 update #660

merged 1 commit into from
Jan 23, 2025

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jan 22, 2025 •
edited by jira bot
Loading

UHF-11098

What was done

  • The select elements on job listing search were limited to max 420px width. This PR changes them back to filling up all the space that this given to them.

How to install

  • Check installation instructions from the hdbt PR.
  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-11098
    • make fresh
  • Run make drush-cr

How to test

  • Check that the job search looks similar to what the current production version looks like.
  • Check that code follows our standards.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Other PRs

@teroelonen teroelonen mentioned this pull request Jan 22, 2025
Merged
2 tasks
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

khalima
khalima approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@khalima khalima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@teroelonen teroelonen merged commit a58f1a2 into dev Jan 23, 2025
3 checks passed
@teroelonen teroelonen deleted the UHF-11098 branch January 23, 2025 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@khalima khalima khalima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teroelonen @khalima