Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UHF-10374: Change the color-silver-light to color-black-5 #669

Merged
merged 2 commits into from
Feb 4, 2025
Merged

UHF-10374: Change the color-silver-light to color-black-5 #669

merged 2 commits into from
Feb 4, 2025

Conversation

teroelonen
Copy link
Contributor

@teroelonen teroelonen commented Jan 31, 2025 •
edited
Loading

UHF-10374

What was done

  • Change the color-silver-light to color-black-5 in the job search element.

How to install

  • Make sure your instance is up and running on correct branch.
    • git checkout UHF-10374
    • make fresh
  • Update the HDBT theme
    • composer require drupal/hdbt:dev-UHF-10374
  • Run make drush-cr

How to test

  • Check that the job search form has now the correct background color (#f2f2f2).
  • Check that code follows our standards.

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Other PRs

This was referenced Jan 31, 2025
Merged
Merged
Merged
Merged
Merged
@teroelonen teroelonen marked this pull request as ready for review January 31, 2025 15:10
annadruid
annadruid approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@annadruid annadruid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@teroelonen teroelonen merged commit 7aef7e1 into dev Feb 4, 2025
3 checks passed
@teroelonen teroelonen deleted the UHF-10374 branch February 4, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annadruid annadruid annadruid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@teroelonen @annadruid