UHF-10559: Add support for secondary key authentication #175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #175 +/- ##
============================================
- Coverage 89.00% 88.94% -0.06%
+ Complexity 518 517 -1
============================================
Files 76 76
Lines 2064 2054 -10
============================================
- Hits 1837 1827 -10
Misses 227 227 ☔ View full report in Codecov by Sentry. |
|
hyrsky
approved these changes
Sep 6, 2024
This was referenced Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to install
composer require drupal/helfi_api_base:dev-UHF-10559<access-key>, but use a valid key in<secondary-access-key>(runecho $DRUPAL_PUBSUB_VAULTinside OpenShift container)How to test
drush helfi:azure:pubsub-listenand make sure an authentication error is raised<secondary-access-key>and make sure the process fails with valid error code (echo $?)