Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UHF-11009: Replace HELFI_DEPLOYMENT_IDENTIFIER in libraries.yml #196

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

hyrsky
Copy link
Member

@hyrsky hyrsky commented Jan 14, 2025

UHF-11009

What was done

How to install

  • Enable varnish composer profile
  • Make sure your instance is up and running on correct branch.
    • composer require drupal/helfi_api_base:dev-UHF-11009
    • make fresh
  • Run make drush-cr

How to test

  • Check that code follows our standards

Continuous documentation

  • This feature has been documented/the documentation has been updated
  • This change doesn't require updates to the documentation

Translations

  • Translations have been added to .po -files and included in this PR

Automatic- / Regression tests

  • This PR makes no changes that effects any tests. (This will be caught in automatic testing later on, but please, please run regression tests always on PR before asking for a review)
  • This PR passes regression tests. (make test-pw)

Other PRs

  • Link to other PR

@hyrsky hyrsky force-pushed the UHF-11009 branch 2 times, most recently from 077baf1 to 98b8a3f Compare January 14, 2025 11:06
@codecov-commenter
Copy link

codecov-commenter commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.52%. Comparing base (c942610) to head (64e0637).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #196      +/-   ##
============================================
- Coverage     88.67%   88.52%   -0.15%     
  Complexity      504      504              
============================================
  Files            76       76              
  Lines          2022     2022              
============================================
- Hits           1793     1790       -3     
- Misses          229      232       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hyrsky hyrsky force-pushed the UHF-11009 branch 2 times, most recently from ff4099c to 11f693e Compare January 14, 2025 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants