Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use of cellsMap #33

Open
benoitgaudou opened this issue Nov 12, 2019 · 2 comments
Open

Use of cellsMap #33

benoitgaudou opened this issue Nov 12, 2019 · 2 comments

Comments

@benoitgaudou
Copy link
Collaborator

The variable managing the code coding from scanner is the following one:

map<int,string> cellsMap<-[1::"Aquaculture", 2::"Rice",3::"Vegetables", 4::"Industrial"];

But, this variable is used as follow:
cell[i,j].type<-cellsMap.values[id];

This seems that the key of cellsMap is never used.
This makes the model hard to update, in particular if we want to manage the -1 value.

@agrignard
Copy link
Collaborator

You're right the key is never used. I can change it to a list of string? I don't see how this make the model harder to update?

agrignard added a commit that referenced this issue Nov 13, 2019
@agrignard
Copy link
Collaborator

Do you prefer this ?
539428e

IF yes I let you close this issue

Also what do you mean by "This makes the model hard to update"? In term of time of update or if we want to modify it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants